Ticket #1115 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

debathena-discuss compile fails under Wheezy

Reported by: bbaren Owned by:
Priority: high Milestone: Precise Alpha
Component: -- Keywords:
Cc: Fixed in version:
Upstream bug:

Description

Upon building debathena-discuss in a Wheezy environment, I get the following compiler error:

acl.c:458:2: error: format not a string literal and no format arguments [-Werror=format-security]

Attachments

patch Download (437 bytes) - added by kcr 10 years ago.
fix

Change History

comment:1 Changed 10 years ago by kaduk

    455 static void panic(s)
    456         char *s;
    457 {
    458         printf(s);

Hmm, panic() should probably be printflike, in an ideal world.

comment:2 Changed 10 years ago by kcr

YAGNI applies. Unless you were planning on doing major discuss development.

comment:3 Changed 10 years ago by achernya

I disagree with Karl, I think it should be made to build, especially since Scripts was asked (relatively recently) to start building and shipping discuss.

comment:4 Changed 10 years ago by kcr

It should absolutely be made to build, but panic() should not at this point grow any more arguments, as Ben appeared to be proposing.

Changed 10 years ago by kcr

fix

comment:5 Changed 9 years ago by jdreed

  • Status changed from new to development

comment:6 Changed 9 years ago by jdreed

  • Status changed from development to proposed

comment:7 Changed 9 years ago by jdreed

  • Status changed from proposed to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.