Ticket #1380 (closed defect: fixed)

Opened 8 years ago

Last modified 7 years ago

chsh.moira is broken

Reported by: kaduk Owned by:
Priority: normal Milestone: The Distant Future
Component: -- Keywords:
Cc: Fixed in version:
Upstream bug:

Description

debathena-moira-clients at svn r4114 is broken, as seen on athena.dialup and reported in help.mit.edu #2490692.
It looks like the (argc < U_END) check in get_shell() is failing, potentially due to mangling of argc done in moira r4114 (which was needed to adjust for the mismatch where affiliation fields are returned by get but not exposed to update. (This is still speculation.)

Change History

comment:1 Changed 8 years ago by jdreed

  • Status changed from new to review

Re-snapshotted moira pushed to my Github. Please review.

comment:2 Changed 8 years ago by jdreed

Re-pushed to my Github with an updated commit message.

Alex says to include this pull request link, so here it is:
 https://github.com/mit-athena/moira/pull/1

comment:3 Changed 8 years ago by jdreed

  • Status changed from review to committed

comment:4 Changed 8 years ago by jdreed

Anders notes I failed to actually ship qy. Trying again, and it looks the pull request also automagically updated.

comment:5 Changed 8 years ago by jdreed

  • Status changed from committed to review

comment:6 Changed 8 years ago by jdreed

  • Status changed from review to development

comment:7 Changed 8 years ago by jdreed

  • Status changed from development to proposed

comment:8 Changed 7 years ago by jdreed

  • Status changed from proposed to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.