openafs 1.6.2.1-1 no longer accepts AFS_DYNROOT=true

[andersk]

As of  this change in openafs 1.6.2.1-1 (jessie+, saucy+, and the PPA), the openafs-client initscript no longer accepts AFS_DYNROOT=true, and instead now accepts AFS_DYNROOT=Yes, unlike the other four options. The postinst tries to convert the configuration over, but that doesn’t help if debathena-afs-config is installed later. In that case, dynroot gets disabled, which causes, like,  kernel panics.

I’ve filed  DebianBug:729353 for this being dumb, but unless we can get a fix in saucy, we may need to fix debathena-afs-config to detect AFS_DYNROOT=true or AFS_DYNROOT=Yes as appropriate.

[jdreed]

Looks like this got fixed upstream and in the PPA, however some Saucy users ended up screwed. I'll test out a new afs-config that fixes this in the postinst, but we should make sure it doesn't trigger an OMINOUS WARNING.

[jdreed]

Well, Github is being dumb, so here's a diff:

diff --git a/debian/afs.conf.client.debathena b/debian/afs.conf.client.debathena
index 9f57054..095f7c7 100644
--- a/debian/afs.conf.client.debathena
+++ b/debian/afs.conf.client.debathena
@@ -3,3 +3,10 @@ AFS_AFSDB=true
 AFS_CRYPT=true
 AFS_DYNROOT=true
 AFS_FAKESTAT=true
+# Clean up from a broken openafs initscript.  See Debathena #1416
+# and Debian #729353
+openafs_ver=$(dpkg-query -W -f '${Version}' openafs-client)
+if dpkg --compare-versions "$openafs_ver" ge 1.6.2.1-1~ &&
+    dpkg --compare-versions "$openafs_ver" lt 1.6.6-1~; then
+    AFS_DYNROOT=Yes
+fi
\ No newline at end of file