Ticket #186 (closed enhancement: fixed)

Opened 13 years ago

Last modified 13 years ago

debathena-afs-config should `fs newcell` in postinst

Reported by: broder Owned by: broder
Priority: normal Milestone:
Component: -- Keywords:
Cc: Fixed in version:
Upstream bug:

Description

If AFS is in use in any way when afs-config is upgraded, it'll fail to restart. If we're pushing updates to the CSDB, that means that the updates won't get taken until after a reboot (or a manual openafs-client restart).

It'd be cool if the postinst went through and ran fs newcell for each cell in the new CSDB.

Change History

comment:1 Changed 13 years ago by broder

I wonder if afs-config's postinst should also schedule a reboot if restarting openafs-client fails?

It looks like you're supposed to do that by running /usr/share/update-notifier/notify-reboot-required, although that doesn't seem to generally exist on non-ubuntu-desktop systems. That script just touches /var/run/reboot-required, which is what debathena-auto-update keys off of to trigger a reboot.

So maybe something like

if ! invoke-rc.d openafs-client restart; then
    if [ -x /usr/share/update-notifier/notify-reboot-required]; then
        /usr/share/update-notifier/notify-reboot-required
    else
        touch /var/run/reboot-required
    fi
fi

The fs newcell loop should be sufficient for most cases, since usually updates to afs-config just change the CSDB. Maybe have an easy way to trigger a reboot on specific upgrades?

comment:3 Changed 13 years ago by broder

  • Owner set to broder
  • Status changed from new to accepted

Fixed in r23739, uploaded to -proposed. Move to production on Tuesday.

comment:4 Changed 13 years ago by broder

I noticed when installing a fresh machine that r23739 caused the install to fail if AFS wasn't already running. I've corrected this in r23741 and uploaded that to proposed.

There was also a change to the CellServDB that I've included.

comment:5 Changed 13 years ago by broder

  • Status changed from accepted to closed
  • Resolution set to fixed

Just deployed to production

Note: See TracTickets for help on using tickets.