Ticket #393 (closed defect: fixed)

Opened 12 years ago

Last modified 12 years ago

remove renew and add from debathena-dotfiles

Reported by: broder Owned by:
Priority: normal Milestone: Karmic Deploy (Canceled)
Component: dotfiles Keywords:
Cc: Fixed in version:
Upstream bug:

Description

The renew and add shell functions are being provided by debathena-shell-config, but they're also in /usr/athena/lib/init/{bash,csh}rc.

Since the Athena dotfiles still source the system dotfiles, there's no reason to have the functions in both places, and in fact they are currently out of sync, so we should punt them from debathena-dotfiles.

Change History

comment:1 Changed 12 years ago by broder

Before somebody goes and blindly tears out the functions, I'll note that we should be sure that we're OK with when the system dotfiles get sourced vs. the Athena dotfiles, and be sure that, e.g., add is defined when we source the user's .{,bash_}environment

comment:2 Changed 12 years ago by tabbott

Note that renew has a different definition between debathena-bash-config and debathena-dotfiles.

comment:3 Changed 12 years ago by broder

I did notice that, and that's one of the reasons I think we should punt it from dotfiles - I'm pretty convinced that the one in bash-config is way better than the one in dotfiles.

comment:4 Changed 12 years ago by broder

  • Status changed from new to proposed

Fix -> proposed

comment:5 Changed 12 years ago by broder

  • Status changed from proposed to closed
  • Resolution set to fixed

Whoops - forgot to close this, but the fix was moved into production earlier today

Note: See TracTickets for help on using tickets.