Ticket #581 (closed enhancement: fixed)

Opened 12 years ago

Last modified 9 years ago

Give shiny icons to the items in the "MIT Software" menu

Reported by: jdreed Owned by: jdreed
Priority: low Milestone: Precise Release
Component: -- Keywords:
Cc: Fixed in version: debathena-locker-menu 1.9 debathena-license-config 1.2
Upstream bug:

Description

The items in the MIT Software menu use the generic "Launcher" icon, which is kind of ugly, especially when every other item in the menu has the same icon.

We should give them shiny (yet redistributable) icons.

Change History

comment:1 Changed 9 years ago by jdreed

  • Milestone changed from The Distant Future to Precise Release

comment:2 Changed 9 years ago by jdreed

  • Owner set to jdreed
  • Status changed from new to accepted

Hrm, I think if we're going to use icons, we should use the Real(tm) icons for the software, as opposed to say, inventing our own MATLAB icon. This ostensibly causes a redistribution problem and makes it Non-Free(tm). We can a) do something stupid like have the package download the icons at build time; b) do something stupider like have the package download the icons at install time, and run them through imagemagick as necessary; c) do something else stupid that results in things like Iceweasel; d) wontfix this; e) do it anyway and explicitly prevent redistribution in the copyright file, though I suspect that violates Debian Policy(tm)

comment:3 Changed 9 years ago by jdreed

Hrm, we can just set Icon=/mit/debathena/whatever.svg (a PNG will also scale down nicely, albeit not up). If the file doesn't exist, it gets a generic "Document" icon. So I think we can just point at things in AFS, assuming Nautilus doesn't grind to a halt if AFS is flaking out. Failing that, we can just Recommend debathena-mit-software-icons-non-free or something.

comment:4 Changed 9 years ago by jdreed

So, uh, this exists:
 http://www.mathworks.com/matlabcentral/fileexchange/24085
which claims to be available under the BSD license. I'm somewhat skeptical, but, uh, given the domain in the URI, maybe it's fine.

comment:5 Changed 9 years ago by jdreed

r25669 and r25670 adds an icon for MATLAB. Some of these are going to be harder. Adobe, of course, has very restrictive terms about their icons, though they do distribute a 32x32 PDF file icon to be used only as a "an active link to a PDF file", and their terms are more permissive if you have signed a license agreement with them (which we have). You can, uh, also take a picture of an Adobe Software box and use that.

Here's my terrible idea for Acrobat Reader:

Index: debian/rules
===================================================================
--- debian/rules	(revision 25590)
+++ debian/rules	(working copy)
@@ -1,3 +1,10 @@
 #!/usr/bin/make -f
 
 include /usr/share/cdbs/1/rules/debhelper.mk
+
+common-install-indep::
+	cp /afs/athena.mit.edu/software/acro/current/distrib/amd64_linux26/Adobe/Reader9/Resource/Icons/64x64/AdobeReader9.png $(CURDIR)/debian/adobe-reader-icon.png
+	dh_install debian/adobe-reader-icon.png usr/share/debathena-locker-menu
+
+clean::
+	rm -f adobe-reader-icon.png
Index: debian/locker-acroread.desktop
===================================================================
--- debian/locker-acroread.desktop	(revision 25590)
+++ debian/locker-acroread.desktop	(working copy)
@@ -13,5 +13,5 @@
 Exec=gathrun acro acroread 
 Terminal=false
 Type=Application
-Icon=gnome-run
+Icon=/usr/share/debathena-locker-menu/adobe-reader-icon.png
 Categories=Locker;

comment:6 Changed 9 years ago by jdreed

  • Status changed from accepted to committed

r25674 / 1.8

The non-free icons are generated at build time, installed in a separate directory, and then depending on the answer to a debconf prompt, either used or not. We should pre-seed this in license-config.

comment:7 Changed 9 years ago by jdreed

  • Fixed in version set to debathena-locker-menu 1.8

comment:8 Changed 9 years ago by jdreed

  • Status changed from committed to development
  • Fixed in version changed from debathena-locker-menu 1.8 to debathena-locker-menu 1.9

Added license-config 1.2

comment:9 Changed 9 years ago by jdreed

  • Status changed from development to proposed

comment:10 Changed 9 years ago by jdreed

  • Fixed in version changed from debathena-locker-menu 1.9 to debathena-locker-menu 1.9 debathena-license-config 1.2

comment:11 Changed 9 years ago by jdreed

  • Status changed from proposed to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.