saferm doesn't deal with largefiles

[jweiss]

When invoked from clean-tmp-areas:

saferm: foo: Value too large for defined data type

[geofft]

I think I fixed this in r24854. However, the feature_test_macros man page confuses me so I would appreciate review.

[andersk]

debathena / r24854 / andersk 20:12 (Anders Kaseorg)

+/* See feature_test_macros(7) */
+#define _FILE_OFFSET_BITS 64

You should do this in a more portable way with AC_SYS_LARGEFILE:
 http://www.gnu.org/software/autoconf/manual/html_node/System-Services.html#index-AC_005fSYS_005fLARGEFILE-1031

debathena / r24854 / geofft 20:14 (Geoffrey Thomas)

So just stick AC_SYS_LARGEFILE in configure.in?

debathena / r24854 / andersk 20:14 (Anders Kaseorg)

Yeah.

[jdreed]

*stares at geofft from having pushed this to -development without updating Trac*

[jdreed]

The ticket did not specify how large "large" was, but I assume 2G is sufficently large:

jdreed@INFINITE-LOOP:~$ ls -lh /tmp/sample-large-file 
-rw-r--r-- 1 jdreed jdreed 2.0G 2011-03-06 18:26 /tmp/sample-large-file
jdreed@INFINITE-LOOP:~$ saferm /tmp/sample-large-file 
jdreed@INFINITE-LOOP:~$ ls -lh /tmp/sample-large-file 
ls: cannot access /tmp/sample-large-file: No such file or directory

[jdreed]

Geoff tells me I wanted > 2G, and it worked with a 6G file.