Ticket #170 (closed defect: fixed)

Opened 12 years ago

Last modified 12 years ago

elinks fifo problem in debathena-login

Reported by: broder Owned by: broder
Priority: normal Milestone:
Component: -- Keywords: proposed
Cc: Fixed in version:
Upstream bug:

Description

debathena-linerva currently replaces elinks with a wrapper that keeps it from trying to open a fifo in your homedir (which you can't do in AFS).

The script should be changed to conditionalize on DEBATHENA_HOME_TYPE. It should be separated into its own packge. That package should divert elinks, but not depend on it, so that it'll work if elinks happens to be installed. And the new package should be added to debathena-locker.

Change History

comment:1 Changed 12 years ago by andersk

   debathena / testers / andersk  15:16  (Anders Kaseorg)
       Uh, it is extremely dangerous to divert a binary without depending on
       it, because it breaks programs that test for the existence of that
       binary.
   debathena / testers / broder  15:18  (Evan Broder)
       Huh?
   debathena / testers / geofft  15:18  (forbidden-config-interpreter)
       A stat will fail... are there really things that will lstat elinks?
   debathena / testers / andersk  15:18  (Anders Kaseorg)
       No, that’s not the point.  The binary really _does_ exist, because it
       is now symlinked to the wrapper script.
   debathena / testers / geofft  15:19  (select-without-choices)
       Oh, right
   debathena / testers / andersk  15:19  (Anders Kaseorg)
       But when you run the wrapper script it will complain about the
       missing .debathena-orig
   debathena / testers / andersk  15:20  (Anders Kaseorg)
       I think you guys are becoming way too comfortable to throw up
       config-package-dev diversions on users’ machines without carefully
       considering the consequences.  c-p-d is not a magical black box that
       solves all your problems.
   debathena / testers / andersk  15:20  (Anders Kaseorg)
       We tried to make a good abstraction, but we simply don’t have the
       tools available to prevent it from leaking in lots of ways.

   debathena / testers / andersk  15:24  (Anders Kaseorg)
       Also, this is not a -locker problem.  This is only a problem with AFS
       _home_ directories, not with the existence lockers.

comment:2 Changed 12 years ago by andersk

  • Summary changed from move elinks diversion to debathena-locker to elinks fifo problem in debathena-login

comment:3 follow-up: ↓ 4 Changed 12 years ago by andersk

Is this problem even worth solving anymore? I think links2 is better maintained than elinks these days, and it doesn’t have the fifo problem at all. I propose removing elinks from -extra-software-nox and declaring this wontfix.

comment:4 in reply to: ↑ 3 Changed 12 years ago by broder

Replying to andersk:

I propose removing elinks from -extra-software-nox and declaring this wontfix.

I agree, and will plan to do so on Saturday if nobody objects.

comment:5 Changed 12 years ago by broder

  • Owner set to broder
  • Keywords proposed added
  • Status changed from new to accepted

Fix uploaded to -proposed. Since this is a simple change, I'll plan to move this to production late Monday.

comment:6 Changed 12 years ago by broder

  • Status changed from accepted to closed
  • Resolution set to wontfix

comment:7 Changed 12 years ago by broder

  • Status changed from closed to reopened
  • Resolution wontfix deleted

Oh whoops - I haven't moved this change to production yet.

comment:8 Changed 12 years ago by broder

  • Status changed from reopened to accepted

comment:9 Changed 12 years ago by broder

  • Status changed from accepted to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.