Ticket #616 (new defect)

Opened 11 years ago

Last modified 7 years ago

Don't use daemon(1) in debathena-metrics

Reported by: broder Owned by:
Priority: trivial Milestone: The Distant Future
Component: -- Keywords:
Cc: Fixed in version:
Upstream bug:

Description

I used to think that daemon(1) was awesome, and way cooler than something more standard like start-stop-daemon. Having actually spent some time looking through its codebase, I'm way less convinced.

(In particular, daemon(1)'s options to manipulate the environment cause it to set variables twice in the child's environment, which is what led to Anders and I discovering CVE-2010-1646)

We should change the debathena-metrics startup and shutdown code to use start-stop-daemon, or teach the metrics gatherer to daemonize itself.

Change History

comment:1 Changed 7 years ago by jdreed

python-daemon is a thing, at least in Precise. The documentation is kind of terrible, but it does everything we need.

Note: See TracTickets for help on using tickets.