Ticket #838 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

libpam_debathena_home_type should not rely on return value of fs whichcell

Reported by: jdreed Owned by:
Priority: normal Milestone: Natty Beta
Component: -- Keywords:
Cc: Fixed in version:
Upstream bug:

Description (last modified by jdreed) (diff)

When AFS isn't running (like, because the module vanished, for example), fs whichcell will return -1, but will say "Function not implemented" instead of "Invalid argument". This results in DEBATHENA_HOME_TYPE getting set to "local", which is all kinds of wrong, and screws up our Xsession.d scripts. It should be more robust to complete loss of AFS and resort to parsing $HOME. Frankly, I'd be in favor of assuming that HOME=/mit/username means AFS, and that if you have your own debathena-standard machine, and create /mit/username locally, you deserve what you get, but I bet someone will disagree with me.

Change History

comment:1 Changed 10 years ago by jdreed

  • Description modified (diff)
  • Summary changed from libpam_debathena_home_type's pants are on fire when AFS isn't running to libpam_debathena_home_type should not rely on return value of fs whichcell

We should possibly also convince OpenAFS that "function not implemented" and "invalid argument" should have different return values, but that's a different ticket.

comment:2 Changed 10 years ago by jdreed

  • Status changed from new to committed

comment:3 Changed 10 years ago by jdreed

  • Status changed from committed to development

comment:4 Changed 10 years ago by jdreed

  • Status changed from development to closed
  • Resolution set to fixed

This moved to proposed last week and is now in production

Note: See TracTickets for help on using tickets.